linux-kernel - Re: [PATCH] tools lib traceevent: Added support for __get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 16 May 2014 09:15:57 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Javi Merino <javi.merino@....com>
Subject: Re: [PATCH] tools lib traceevent: Added support for __get_bitmask()
 macro

On Thu, May 15, 2014 at 06:18:52PM -0400, Steven Rostedt wrote:
> 
> Coming in v3.16, trace events will be able to save bitmasks in raw
> format in the ring buffer and output it with the __get_bitmask() macro.
> 
> In order for userspace tools to parse this, it must be able to handle
> the __get_bitmask() call and be able to convert the data that's in
> the ring buffer into a nice bitmask format. The output is similar to
> what the kernel uses to print bitmasks, with a comma separator every
> 4 bytes (8 characters).
> 
> This allows for cpumasks to also be saved efficiently.
> 
> The first user is the thermal:thermal_power_limit event which has the
> following output:
> 
>  thermal_power_limit:  cpus=0000000f freq=1900000 cdev_state=0 power=5252

needs also an update in python and perf code:

[jolsa@...va perf]$ make
SNIP

...                       libnuma: [ on  ]
...                       libperl: [ on  ]

SNIP

  CC       scripts/perl/Perf-Trace-Util/Context.o
  CC       util/scripting-engines/trace-event-python.o
  CC       scripts/python/Perf-Trace-Util/Context.o
util/scripting-engines/trace-event-python.c: In function ‘define_event_symbols’:
util/scripting-engines/trace-event-python.c:155:2: error: enumeration value ‘PRINT_BITMASK’ not handled in switc
  switch (args->type) {
  ^
cc1: all warnings being treated as errors
make[1]: *** [util/scripting-engines/trace-event-python.o] Error 1
make[1]: *** Waiting for unfinished jobs....
util/scripting-engines/trace-event-perl.c: In function ‘define_event_symbols’:
util/scripting-engines/trace-event-perl.c:188:2: error: enumeration value ‘PRINT_BITMASK’ not handled in switch 
  switch (args->type) {
  ^
cc1: all warnings being treated as errors
make[1]: *** [util/scripting-engines/trace-event-perl.o] Error 1
make: *** [all] Error 2

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/