| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5377A1CC.7020104@posteo.de> Date: Sat, 17 May 2014 19:52:12 +0200 From: Martin Kepplinger <martink@...teo.de> To: Antti Palosaari <crope@....fi>, gregkh@...uxfoundation.org, Devin Heitmueller <dheitmueller@...nellabs.com> CC: m.chehab@...sung.com, linux-media@...r.kernel.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCHv2] staging: media: as102: replace custom dprintk() with dev_dbg() Am 2014-05-17 19:21, schrieb Antti Palosaari: > On 05/17/2014 07:05 PM, Martin Kepplinger wrote: >> don't reinvent dev_dbg(). remove dprintk() in as102_drv.c. >> use the common kernel coding style. >> >> Signed-off-by: Martin Kepplinger <martink@...teo.de> > > Reviewed-by: Antti Palosaari <crope@....fi> > >> --- >> this applies to next-20140516. any more suggestions? >> more cleanup can be done when dprintk() is completely gone. > > Do you have the device? I am a bit reluctant patching that driver > without any testing as it has happened too many times something has gone > totally broken. I don't have the device and will, at most, change such style issues. > > IIRC Devin said it is in staging because of style issues and nothing > more. Is that correct? I haven't heard anything. A TODO file would help. > > regards > Antti > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists