linux-kernel - Re: [PATCH 1/2] Input: Add keycodes for some missing Fn key combinations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201405172238.30089@pali>
Date:	Sat, 17 May 2014 22:38:30 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>, linux-input@...r.kernel.org,
	platform-driver-x86@...r.kernel.org, linux-hotplug@...r.kernel.org,
	Matthew Garrett <mjg@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Input: Add keycodes for some missing Fn key combinations

On Saturday 17 May 2014 22:30:54 Dmitry Torokhov wrote:
> Hi Pali,
> 
> On Sat, May 17, 2014 at 04:43:36PM +0200, Pali Rohár wrote:
> > There are already defined some Fn key combinations, but not
> > all. This patch adds missing combinations for support in
> > dell-wmi driver.
> > 
> > Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> > ---
> > 
> >  include/uapi/linux/input.h |    6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/include/uapi/linux/input.h
> > b/include/uapi/linux/input.h index f484952..3a32799 100644
> > --- a/include/uapi/linux/input.h
> > +++ b/include/uapi/linux/input.h
> > @@ -672,6 +672,12 @@ struct input_keymap_entry {
> > 
> >  #define KEY_FN_F		0x1e2
> >  #define KEY_FN_S		0x1e3
> >  #define KEY_FN_B		0x1e4
> > 
> > +#define KEY_FN_Q		0x1e5
> > +#define KEY_FN_W		0x1e6
> > +#define KEY_FN_R		0x1e7
> > +#define KEY_FN_T		0x1e8
> > +#define KEY_FN_A		0x1e9
> > +#define KEY_FN_G		0x1ea
> 
> What do they actually do?
> 
> Thanks.

All 10 combinations Fn+Q ... Fn+T, Fn+A ... Fn+G are reported by 
WMI and I need to assign some keycodes for them in dell-wmi 
driver. And because More FN_* constants are already defined in 
input.h I added those which are missing.

With this patch series I'm able to use above Fn combinations for 
my own keyboard shortcuts. Before this patch all Fn combinations 
were one same keycode - which was useless.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)