linux-kernel - Re: [PATCH] clk: tegra: Fix wrong value written to PLLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140517210657.GB1046@mithrandir>
Date:	Sat, 17 May 2014 23:06:59 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Tuomas Tynkkynen <ttynkkynen@...dia.com>,
	Mike Turquette <mturquette@...aro.org>,
	Peter De Schrijver <pdeschrijver@...dia.com>,
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH] clk: tegra: Fix wrong value written to PLLE_AUX

On Fri, May 16, 2014 at 10:05:18AM -0600, Stephen Warren wrote:
> On 05/16/2014 08:31 AM, Thierry Reding wrote:
> > On Fri, May 16, 2014 at 04:50:20PM +0300, Tuomas Tynkkynen wrote:
> >> The value written to PLLE_AUX was incorrect due to a wrong variable
> >> being used.
> >>
> >> Signed-off-by: Tuomas Tynkkynen <ttynkkynen@...dia.com>
> >> Tested-by: Mikko Perttunen <mperttunen@...dia.com>
> >> ---
> >>   This fix is required for the (upcoming) SATA support.
> >>  drivers/clk/tegra/clk-pll.c |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Reviewed-by: Thierry Reding <treding@...dia.com>
> > Tested-by: Thierry Reding <treding@...dia.com>
> > Acked-by: Thierry Reding <treding@...dia.com>
> > 
> > Mike, Peter, it might be good to have this go into 3.16 as a
> > prerequisite for the upcoming SATA driver (which presumably won't be
> > ready until 3.17, but in that case it would be good to have this
> > prerequisite merged already).
> 
> Probably even Cc: stable since it's a fix for a bug that I assume has
> been in a kernel release or two?

Yeah, I guess that makes sense. The bug isn't visible yet, but back-
porting to stable might save somebody else from chasing this if they
ever decide to backport PCIe, SATA or XUSB.

Thierry

Content of type "application/pgp-signature" skipped