linux-kernel - Re: [PATCH 3/4] staging: dgnc: dgnc_neo: Fix conditional part of if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140517212353.GH15585@mwanda>
Date:	Sun, 18 May 2014 00:23:54 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Masaru Nomura <massa.nomura@...il.com>
Cc:	devel@...verdev.osuosl.org, Lidza Louina <lidza.louina@...il.com>,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH 3/4] staging: dgnc: dgnc_neo: Fix conditional part of if
 statement

On Sat, May 17, 2014 at 10:14:52PM +0100, Masaru Nomura wrote:
> > Also just fold this patch and [patch 2/4] together into one patch.  We
> > don't need two patches to fix one if statement.
> >
> > The one thing per patch rule is a bit tricky.  It means that you have to
> > say which one thing you are fixing.  Don't say "I am fixing three
> > things."  Say "I am fixing one if statement".
> 
> So in this case, do you think I could fold all four patches into one?

No.  That would be more than one thing per patch.  It looks like this:

[patch 1/3] staging: dgnc: dgnc_neo: put else statements on the right line
[patch 2/3] staging: dgnc: dgnc_neo: clean up ugly one very ugly condition
[patch 3/3] staging: dgnc: dgnc_neo: remove extra curly braces

Each patch does one thing.  Cleaning up the whole file is too big so it
doesn't count as doing one thing only.

> As I just worked on the 'same' if statements and divided them into
> four patches, this could be the case. (but I'm not sure yet...)
> 
> Also, should I put v[number] for the modified patches?
> Say [PATCH v2] staging: ...

Yes.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/