linux-kernel - Re: [PATCH] x86/mce: Clear a useless global variable in mce.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140517095838.GA23100@pd.tnic>
Date:	Sat, 17 May 2014 11:58:38 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Chen Yucong <slaoub@...il.com>
Cc:	tony.luck@...el.com, linux-kernel@...r.kernel.org,
	linux-edac@...r.kernel.org
Subject: Re: [PATCH] x86/mce: Clear a useless global variable in mce.c

On Sat, May 17, 2014 at 04:45:24PM +0800, Chen Yucong wrote:
> This patch is just used to remove a useless global variable mce_entry
> and relative operations in mce.c.

Well, I can see from the diff below what you're saying here but a commit
message should contain information which explains *why* you're doing the
change and not *what* you're doing - that we can see.

IOW, you could instead do some git history research and write in your
commit message why this mce_entry got unused and quote commits which
removed it, why they removed it and why we want to remove the remains of
it now.

In any case, the change itself is correct, I would like to have a commit
message which explains why we're removing it.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/