linux-kernel - Re: [PATCH] staging: media: as102: replace custom dprintk() with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53776B57.5050504@iki.fi>
Date:	Sat, 17 May 2014 16:59:51 +0300
From:	Antti Palosaari <crope@....fi>
To:	Martin Kepplinger <martink@...teo.de>, gregkh@...uxfoundation.org
CC:	m.chehab@...sung.com, linux-media@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: as102: replace custom dprintk() with
 dev_dbg()

you forget to remove debug parameter itself.

Antti


On 05/17/2014 04:16 PM, Martin Kepplinger wrote:
> don't reinvent dev_dbg(). use the common kernel coding style.
>
> Signed-off-by: Martin Kepplinger <martink@...teo.de>
> ---
> this applies to next-20140516.
>
>   drivers/staging/media/as102/as102_drv.c |   11 +++++++----
>   1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/as102/as102_drv.c b/drivers/staging/media/as102/as102_drv.c
> index 09d64cd..99c3ed93 100644
> --- a/drivers/staging/media/as102/as102_drv.c
> +++ b/drivers/staging/media/as102/as102_drv.c
> @@ -74,7 +74,8 @@ static void as102_stop_stream(struct as102_dev_t *dev)
>   			return;
>
>   		if (as10x_cmd_stop_streaming(bus_adap) < 0)
> -			dprintk(debug, "as10x_cmd_stop_streaming failed\n");
> +			dev_dbg(&dev->bus_adap.usb_dev->dev,
> +				"as10x_cmd_stop_streaming failed\n");
>
>   		mutex_unlock(&dev->bus_adap.lock);
>   	}
> @@ -112,14 +113,16 @@ static int as10x_pid_filter(struct as102_dev_t *dev,
>   	int ret = -EFAULT;
>
>   	if (mutex_lock_interruptible(&dev->bus_adap.lock)) {
> -		dprintk(debug, "mutex_lock_interruptible(lock) failed !\n");
> +		dev_dbg(&dev->bus_adap.usb_dev->dev,
> +			"amutex_lock_interruptible(lock) failed !\n");
>   		return -EBUSY;
>   	}
>
>   	switch (onoff) {
>   	case 0:
>   		ret = as10x_cmd_del_PID_filter(bus_adap, (uint16_t) pid);
> -		dprintk(debug, "DEL_PID_FILTER([%02d] 0x%04x) ret = %d\n",
> +		dev_dbg(&dev->bus_adap.usb_dev->dev,
> +			"DEL_PID_FILTER([%02d] 0x%04x) ret = %d\n",
>   			index, pid, ret);
>   		break;
>   	case 1:
> @@ -131,7 +134,7 @@ static int as10x_pid_filter(struct as102_dev_t *dev,
>   		filter.pid = pid;
>
>   		ret = as10x_cmd_add_PID_filter(bus_adap, &filter);
> -		dprintk(debug,
> +		dev_dbg(&dev->bus_adap.usb_dev->dev,
>   			"ADD_PID_FILTER([%02d -> %02d], 0x%04x) ret = %d\n",
>   			index, filter.idx, filter.pid, ret);
>   		break;
>


-- 
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/