[<prev] [next>] [day] [month] [year] [list]
Message-Id: <1400428783-10162-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Date: Sun, 18 May 2014 17:59:43 +0200
From: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To: Nagalakshmi Nandigama <Nagalakshmi.Nandigama@....com>,
Sreekanth Reddy <Sreekanth.Reddy@....com>
Cc: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
support@....com, DL-MPTFusionLinux@....com,
linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] message: fusion: mptscsih.c: Fix for possible null pointer dereference
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
---
drivers/message/fusion/mptscsih.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/message/fusion/mptscsih.c b/drivers/message/fusion/mptscsih.c
index 727819c..b323b23 100644
--- a/drivers/message/fusion/mptscsih.c
+++ b/drivers/message/fusion/mptscsih.c
@@ -1279,9 +1279,11 @@ mptscsih_info(struct Scsi_Host *SChost)
mpt_print_ioc_summary(h->ioc, h->info_kbuf, &size, 0, 0);
h->info_kbuf[size-1] = '\0';
+
+ return h->info_kbuf;
}
- return h->info_kbuf;
+ return NULL;
}
int mptscsih_show_info(struct seq_file *m, struct Scsi_Host *host)
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists