[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1400429349-11040-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Date: Sun, 18 May 2014 18:09:09 +0200
From: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To: Oliver Neukum <oliver@...kum.org>, Ali Akcaagac <aliakc@....de>
Cc: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
Jamie Lenehan <lenehan@...bble.org>,
"James E.J. Bottomley" <JBottomley@...allels.com>,
dc395x@...bble.org, linux-scsi@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] scsi: dc395x.c: Fix for possible null pointer dereference
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
---
drivers/scsi/dc395x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index 83d9bf6..0d86bc7 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -2637,7 +2637,7 @@ static struct ScsiReqBlk *msgin_qtag(struct AdapterCtlBlk *acb,
struct ScsiReqBlk *srb = NULL;
struct ScsiReqBlk *i;
dprintkdbg(DBG_0, "msgin_qtag: (0x%p) tag=%i srb=%p\n",
- srb->cmd, tag, srb);
+ srb ? srb->cmd : 0, tag, srb);
if (!(dcb->tag_mask & (1 << tag)))
dprintkl(KERN_DEBUG,
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists