linux-kernel - Re: [PATCH 1/2] staging: slicoss: rewrite eeprom checksum code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANoiuGJC4CcZf-dzBQjFE72eBsb0zXTy4vxeE87cngT=kEiTVA@mail.gmail.com>
Date:	Sat, 17 May 2014 21:51:45 -0700
From:	David Matlack <matlackdavid@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org, Lior Dotan <liodot@...il.com>,
	charrer@...critech.com
Subject: Re: [PATCH 1/2] staging: slicoss: rewrite eeprom checksum code

On Sat, May 17, 2014 at 9:12 PM, Joe Perches <joe@...ches.com> wrote:
> On Sat, 2014-05-17 at 21:00 -0700, David Matlack wrote:
> []
>> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> []
>> +static inline u16 __reduce(u32 checksum)
>> +{
>> +     u16 lower_16 = checksum & 0xFFFF;
>> +     u16 upper_16 = (checksum >> 16) & 0xFFFF;
>> +
>> +     checksum = lower_16 + upper_16;
>> +
>> +     if (checksum > 65535)
>> +             checksum -= 65535;
>> +
>> +     return checksum;
>> +}
>
> The if seems unnecessary.
>
> Perhaps declare a u16 return var or use
>
>         return lower_16 + upper_16;

I agree it's fishy... but using overflow doesn't produce the same result:

         (u16) 65536   == 0
         65536 - 65535 == 1

Now which is the correct result, I have no idea. The eeprom on this device is
small (0x80 bytes max, not enough to trigger overflow) and I have no
documentation, so I don't know how to test :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/