linux-kernel - Re: [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAvxhqD0zS9+W0Jx3Ut+MQfCWzMmSDwdo+t9mEaL655BRT8qGg@mail.gmail.com>
Date:	Sun, 18 May 2014 20:12:39 +0100
From:	Masaru Nomura <massa.nomura@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	gregkh@...uxfoundation.org, andreas.dilger@...el.com,
	oleg.drokin@...el.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

>> -     memset (peer, 0, sizeof (*peer));       /* NULL pointers/clear flags etc */
>> +     memset(peer, 0, sizeof(*peer));     /* NULL pointers/clear flags etc */
>
> It looks like this memset is unnecessary
> as it's already zeroed by LIBCFS_ALLOC->
> LIBCFS_ALLOC_GFP->LIBCFS_ALLOC_POST->memset.
>
> It seems as if all these ALLOC macros could
> use quite a bit of cleaning/sorting out.

Thank you for pointing it out. I didn't know that nor check the macros.
I'll care about similar problems next time.

I checked the macros and kind of understand what you mean,
but honestly I'm not sure whether or not it's perfectly correct to
remove memset.

If this is the right way, I think we can remove the following memset
which I modified as well.
The reason is the same as you mentioned. conn is zeroed by
LIBCFS_ALLOC before memset.

[PATCH 1/5]
@@ -1041,26 +1041,26 @@ ksocknal_create_conn (lnet_ni_t *ni,
ksock_route_t *route,
                goto failed_0;
        }

-       memset (conn, 0, sizeof (*conn));
+       memset(conn, 0, sizeof(*conn));


Thank you,
Masaru
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/