linux-kernel - Re: [PATCH] Input: ims-pcu - fix uninitialized use of 'error' in ims_pcu_buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140518230058.GA27053@core.coreip.homeip.net>
Date:	Sun, 18 May 2014 16:00:58 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Christian Engelmayer <cengelma@....at>
Cc:	linux-input@...r.kernel.org, andrew.smirnov@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: ims-pcu - fix uninitialized use of 'error' in
 ims_pcu_buffers_alloc()

On Sun, May 18, 2014 at 11:41:18PM +0200, Christian Engelmayer wrote:
> In case allocation via usb_alloc_coherent() fails in ims_pcu_buffers_alloc(),
> the function jumps to the exit path without initializing local variable
> 'error' that is used as return value. Detected by Coverity - CID 1016531.
> 
> Signed-off-by: Christian Engelmayer <cengelma@....at>

Applied, thank you.

> ---
> This is an allocation function and all currently coded error scenarios
> result in -ENOMEM. Thus it would be possible to eliminate 'error' at all and
> always return -ENOMEM in the error path.
> 
> Compile tested. Applies against branch next in tree
> git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
> ---
>  drivers/input/misc/ims-pcu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
> index 5a73639..719410f 100644
> --- a/drivers/input/misc/ims-pcu.c
> +++ b/drivers/input/misc/ims-pcu.c
> @@ -1566,6 +1566,7 @@ static int ims_pcu_buffers_alloc(struct ims_pcu *pcu)
>  	if (!pcu->urb_ctrl_buf) {
>  		dev_err(pcu->dev,
>  			"Failed to allocate memory for read buffer\n");
> +		error = -ENOMEM;
>  		goto err_free_urb_out_buf;
>  	}
>  
> -- 
> 1.9.1
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/