linux-kernel - Re: [PATCH v2 02/06] staging: crypto: skein: rename camelcase vars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140519090246.GQ15585@mwanda>
Date:	Mon, 19 May 2014 12:02:46 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Anton Saraev <antonysaraev@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, jason@...edaemon.net, jake@....net
Subject: Re: [PATCH v2 02/06] staging: crypto: skein: rename camelcase vars

On Mon, May 19, 2014 at 12:09:55PM +0400, Anton Saraev wrote:
>  #if SKEIN_UNROLL_256 == 0
> -#define R256(p0, p1, p2, p3, ROT, rNum) /* fully unrolled */ \
> +#define R256(p0, p1, p2, p3, ROT, r_num) /* fully unrolled */ \
>  do { \
> -	Round256(p0, p1, p2, p3, ROT, rNum) \
> -	Skein_Show_R_Ptr(BLK_BITS, &ctx->h, rNum, Xptr); \
> +	Round256(p0, p1, p2, p3, ROT, r_num); \
> +	Skein_Show_R_Ptr(BLK_BITS, &ctx->h, r_num, X_ptr); \

Adding a semi-colon here looks suspiciously like a compile fix.  It's
great that you're fixing bugs, but do it in a separate patch with a
changelog.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/