linux-kernel - Re: [PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5379E177.2030707@linaro.org>
Date:	Mon, 19 May 2014 12:48:23 +0200
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	'Thomas Gleixner' <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org,
	'Shinya Kuribayashi' <shinya.kuribayashi.px@...esas.com>,
	'Magnus Damm' <damm@...nsource.se>
Subject: Re: [PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages

On 04/29/2014 10:26 AM, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.

Are you sure the MM subsys display a message when an allocation fails ?

There are multiple reasons an allocation can fail.

> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>   drivers/clocksource/em_sti.c |    4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c
> index 9d17083..d0a7bd6 100644
> --- a/drivers/clocksource/em_sti.c
> +++ b/drivers/clocksource/em_sti.c
> @@ -318,10 +318,8 @@ static int em_sti_probe(struct platform_device *pdev)
>   	int irq;
>
>   	p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
> -	if (p == NULL) {
> -		dev_err(&pdev->dev, "failed to allocate driver data\n");
> +	if (p == NULL)
>   		return -ENOMEM;
> -	}
>
>   	p->pdev = pdev;
>   	platform_set_drvdata(pdev, p);
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/