linux-kernel - Re: [PATCH v2 05/06] staging: crypto: skein: rename macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140519140405.GF27822@titan.lakedaemon.net>
Date:	Mon, 19 May 2014 10:04:05 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Anton Saraev <antonysaraev@...il.com>, gregkh@...uxfoundation.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	jake@....net
Subject: Re: [PATCH v2 05/06] staging: crypto: skein: rename macros

On Mon, May 19, 2014 at 12:08:39PM +0300, Dan Carpenter wrote:
> On Mon, May 19, 2014 at 12:09:58PM +0400, Anton Saraev wrote:
> > +/* ignore all asserts, for performance */
> > +#define skein_assert_ret(x, ret_code)
> > +#define skein_assert(x)
> 
> Not related to this patch, but defining away asserts like this is a bad
> idea.  What if they have side affects like:
> 
> 	skein_assert(foo++ == bar);

Agreed.  This driver is definitely a work in progress.  If you look at
the history, you'll see that I started with a bit-for-bit copy of a
publicly available reference implementation.  After we get the coding
style in shape, there are plenty of other improvements to make.

Thanks for the review.

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/