linux-kernel - Re: [PATCH] HID: rmi: do not handle touchscreens through hid-rmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN+gG=HtdpTkZ6eo_WCBuwy_XkEjycb12jtj4eBo=P1goJUeeg@mail.gmail.com>
Date:	Mon, 19 May 2014 10:59:04 -0400
From:	Benjamin Tissoires <benjamin.tissoires@...il.com>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:	Jiri Kosina <jkosina@...e.cz>,
	Andrew Duggan <aduggan@...aptics.com>,
	Christopher Heiny <cheiny@...aptics.com>,
	linux-input <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: rmi: do not handle touchscreens through hid-rmi

On Wed, Apr 23, 2014 at 10:31 AM, Benjamin Tissoires
<benjamin.tissoires@...hat.com> wrote:
> Currently, hid-rmi drives every Synaptics product, but the touchscreens
> on the Windows tablets should be handled through hid-multitouch.
>
> Instead of providing a long list of PIDs, rely on the scan_report
> capability to detect which should go to hid-multitouch, and which
> should not go to hid-rmi.
>
> We introduce a generic HID_GROUP_HAVE_SPECIAL_DRIVER which can be reused
> amoung other drivers if they want to have a catch rule but still
> have multitouch devices handled through hid-multitouch.
>
> related bug:
> https://bugzilla.kernel.org/show_bug.cgi?id=74241
> https://bugzilla.redhat.com/show_bug.cgi?id=1089583
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> ---
>
> Hi Jiri,
>
> well, this is the patch we are going to carry in Fedora as we are already
> carrying hid-rmi.
> Still, I am not 100% happy with it, especially the HID_GROUP_HAVE_SPECIAL_DRIVER
> thing.
>
> I would also say we should re-think the way the scanning is called in
> hid_add_device because I am starting using more and more the scanning capability
> to decide if the device should be handled by generic, a special driver or simply
> ignored.
>
> Anyway, this could be decided later. If you prefer me to use a hid-rmi specific
> group like HID_GROUP_RMI instead of HID_GROUP_HAVE_SPECIAL_DRIVER, I can also
> update the patch.
>

Hi Jiri,

looks like this one did not attracted your eye yet. Can you ack / nack it?
Without it, hid-rmi will break all the multitouch screens from
Synaptics, which will be a little bit worrying :)

Cheers,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/