[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMuHMdURE+rJ4jPhPRwsKqn1egzoWpidzYc0aPP=aSGbjMj11g@mail.gmail.com>
Date: Mon, 19 May 2014 17:01:03 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Rob Herring <robherring2@...il.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Rob Herring <robh@...nel.org>,
Florian Vaussard <florian.vaussard@...l.ch>,
Joe Perches <joe@...ches.com>,
Andy Whitcroft <apw@...onical.com>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] checkpatch: fix wildcard DT compatible string checking
On Thu, Apr 10, 2014 at 3:41 PM, Rob Herring <robherring2@...il.com> wrote:
> From: Rob Herring <robh@...nel.org>
>
> We attempt to search for compatible strings which use a variable
> token in the documented name such as <chip> or <soc>. While this
> was attempted to be handled, it's utterly broken.
>
> The desired forms of matching are:
>
> vendor,<chip>-*
> vendor,name<part#>-*
>
> For <chip>, lower case characters and numbers are permitted. For
> <part#>, only numeric values are allowed.
>
> With this change, the number of missing compatible strings reported in
> arch/arm/boot/dts is reduced from 1071 to 960.
>
> Reported-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> Signed-off-by: Rob Herring <robh@...nel.org>
> Cc: Florian Vaussard <florian.vaussard@...l.ch>
> Cc: Joe Perches <joe@...ches.com>
> Cc: Andy Whitcroft <apw@...onical.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
As I came up with about the same patch while investigating why it didn't
work for me:
Tested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists