linux-kernel - Re: [PATCH 2/2] staging: slicoss: remove slic_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANoiuGLjBwitL_==2xVQ_021p=3uOCf2qwqWYdrmiRE7rQM0FQ@mail.gmail.com>
Date:	Mon, 19 May 2014 08:57:49 -0700
From:	David Matlack <matlackdavid@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	charrer@...critech.com, linux-kernel@...r.kernel.org,
	Lior Dotan <liodot@...il.com>
Subject: Re: [PATCH 2/2] staging: slicoss: remove slic_reg_params struct

On Mon, May 19, 2014 at 2:21 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> Looking at the patch, this looks like a bugfix but the changelog doesn't
> give any clues.

Yeah this isn't a bug fix.

The only member of struct slic_reg_params that was in use was fail_on_bad_eeprom
(implicitly set to zero by alloc_etherdev -> kzalloc). Since the previous patch
in this series fixes the eeprom checksum, we can remove this struct entirely.

If we do want the feature of ignoring a corrupt/bad eeprom, a module param
would work better anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/