linux-kernel - Re: [PATCH] clk: twl6040: Convert to use devm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 19 May 2014 19:32:52 +0300
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	Axel Lin <axel.lin@...ics.com>,
	Mike Turquette <mturquette@...aro.org>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: twl6040: Convert to use devm_clk_register

On 05/18/2014 06:42 PM, Axel Lin wrote:
> Use devm_clk_register() to simplify the code by removing twl6040_clk_remove().

Acked-by: Peter Ujfalusi <peter.ujfalusi@...com>

> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/clk/clk-twl6040.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/drivers/clk/clk-twl6040.c b/drivers/clk/clk-twl6040.c
> index 1ada79a..9e996b4 100644
> --- a/drivers/clk/clk-twl6040.c
> +++ b/drivers/clk/clk-twl6040.c
> @@ -91,7 +91,7 @@ static int twl6040_clk_probe(struct platform_device *pdev)
>  	clkdata->twl6040 = twl6040;
>  
>  	clkdata->mcpdm_fclk.init = &wm831x_clkout_init;
> -	clkdata->clk = clk_register(&pdev->dev, &clkdata->mcpdm_fclk);
> +	clkdata->clk = devm_clk_register(&pdev->dev, &clkdata->mcpdm_fclk);
>  	if (IS_ERR(clkdata->clk))
>  		return PTR_ERR(clkdata->clk);
>  
> @@ -100,22 +100,12 @@ static int twl6040_clk_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static int twl6040_clk_remove(struct platform_device *pdev)
> -{
> -	struct twl6040_clk *clkdata = platform_get_drvdata(pdev);
> -
> -	clk_unregister(clkdata->clk);
> -
> -	return 0;
> -}
> -
>  static struct platform_driver twl6040_clk_driver = {
>  	.driver = {
>  		.name = "twl6040-clk",
>  		.owner = THIS_MODULE,
>  	},
>  	.probe = twl6040_clk_probe,
> -	.remove = twl6040_clk_remove,
>  };
>  
>  module_platform_driver(twl6040_clk_driver);
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/