linux-kernel - Re: [PATCH v2] staging: comedi: ii_pci20kc: fix usage of uninit scalar in ii20k

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <537A3696.6080902@mev.co.uk>
Date:	Mon, 19 May 2014 17:51:34 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Christian Engelmayer <cengelma@....at>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
CC:	"hsweeten@...ionengravers.com" <hsweeten@...ionengravers.com>,
	Ian Abbott <Ian.Abbott@....co.uk>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] staging: comedi: ii_pci20kc: fix usage of uninit scalar
 in ii20k_attach()

On 2014-05-07 20:45, Christian Engelmayer wrote:
> This driver supports the PCI-20001C-1a and PCI-20001C-2a carrier boards.
> The -2a version has 32 on-board DIO channels. In case this variant is
> detected, local variable 'has_dio' is set accordingly. Otherwise it is
> left uninitialized and the following subdevice instantiation depends on
> the stack. Detected by Coverity - CID 1077830.
>
> Signed-off-by: Christian Engelmayer <cengelma@....at>
> ---
> v2: Resend after v1 failed to apply
>
>     * rebased against staging-next - commit 09c3fbba (staging: rtl8188eu:
>       Remove 'u8 *pbuf' from struct recv_buf)
>     * fixed mua: no multipart, 7bit text/plain us-ascii
>
> Compile tested and applies against branch staging-next of tree
> git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> ---
>   drivers/staging/comedi/drivers/ii_pci20kc.c | 1 +
>   1 file changed, 1 insertion(+)

Thanks!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/