linux-kernel - Re: [PATCH 2/5] usb: gadget: net2280: Use S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1405191527520.1538-100000@iolanthe.rowland.org>
Date:	Mon, 19 May 2014 15:30:50 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
cc:	balbi@...com, <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<joe@...ches.com>, <auttamchandani@...icube.com>
Subject: Re: [PATCH 2/5] usb: gadget: net2280: Use S_I macros

On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:

> Instead of octal notation, to be consistent around the file.
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> ---
>  drivers/usb/gadget/net2280.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
> index c3205ec..5b2ab68 100644
> --- a/drivers/usb/gadget/net2280.c
> +++ b/drivers/usb/gadget/net2280.c
> @@ -111,7 +111,7 @@ module_param(use_msi, bool, S_IRUGO);
>  static ushort fifo_mode = 0;
>  
>  /* "modprobe net2280 fifo_mode=1" etc */
> -module_param (fifo_mode, ushort, 0644);
> +module_param(fifo_mode, ushort, S_IRUGO | S_IWUSR);

I don't think this is necessary, in and of itself.  In my opinion, the 
macros are a lot harder to figure out than the octal values.

Don't bother making this change.  It's useless churn.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/