linux-kernel - Re: [PATCH] HID: core: fix validation of report id 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN+gG=FDjtX9Sz9Hy=NT0zJV6y0sbJLJav=S0S2V=+v++EE6bg@mail.gmail.com>
Date:	Mon, 19 May 2014 15:39:54 -0400
From:	Benjamin Tissoires <benjamin.tissoires@...il.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Jiri Kosina <jkosina@...e.cz>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Simon Wood <simon@...gewell.org>,
	linux-input <linux-input@...r.kernel.org>,
	Roland Bosa <rbosa@...itech.com>
Subject: Re: [PATCH] HID: core: fix validation of report id 0

On Mon, May 19, 2014 at 3:01 PM, Kees Cook <keescook@...omium.org> wrote:
> Pinging on this patch... I don't see it in -next yet. I've had more
> reports of trouble with logitech devices, and this seems to solve the
> problem.
>
> -Kees
>
> On Thu, Apr 17, 2014 at 1:22 PM, Kees Cook <keescook@...omium.org> wrote:
>> Some drivers use the first HID report in the list instead of using an
>> index. In these cases, validation uses ID 0, which was supposed to mean
>> "first known report". This fixes the problem, which was causing at least
>> the lgff family of devices to stop working since hid_validate_values
>> was being called with ID 0, but the devices used single numbered IDs
>> for their reports:
>>
>> 0x05, 0x01,         /*  Usage Page (Desktop),                   */
>> 0x09, 0x05,         /*  Usage (Gamepad),                        */
>> 0xA1, 0x01,         /*  Collection (Application),               */
>> 0xA1, 0x02,         /*      Collection (Logical),               */
>> 0x85, 0x01,         /*          Report ID (1),                  */
>> ...
>>
>> Reported-by: Simon Wood <simon@...gewell.org>
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>> Cc: stable@...r.kernel.org
>> ---

Oops, sorry, I should have commented on it earlier:

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Cheers,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/