linux-kernel - Re: [PATCH 1/1] fs/jffs2/compr.c: remove 0 assignment on static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1400529199.14238.24.camel@joe-AO725>
Date:	Mon, 19 May 2014 12:53:19 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 1/1] fs/jffs2/compr.c: remove 0 assignment on static

On Mon, 2014-05-19 at 21:31 +0200, Fabian Frederick wrote:
> static values are automatically initialized to NULL
[]
> diff --git a/fs/jffs2/compr.c b/fs/jffs2/compr.c
[]
> @@ -25,7 +25,8 @@ static LIST_HEAD(jffs2_compressor_list);
>  static int jffs2_compression_mode = JFFS2_COMPR_MODE_PRIORITY;
>  
>  /* Statistics for blocks stored without compression */
> -static uint32_t none_stat_compr_blocks=0,none_stat_decompr_blocks=0,none_stat_compr_size=0;
> +static uint32_t none_stat_compr_blocks, none_stat_decompr_blocks,
> +		none_stat_compr_size;

Maybe nicer on 3 lines.

static uint32_t none_stat_compr_blocks;
static uint32_t none_stat_decompr_blocks,
static uint32_t none_stat_compr_size;

These none_stat_<foo> variables seem to
be write only so it'd probably be better
to remove them instead.

Maybe all the uint32_t uses in fs/jffs2/
would be nicer as u32.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/