linux-kernel - Re: [PATCH 2/2] staging: slicoss: remove slic_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANoiuGKKjEvLzb70JNQWe=P6GY3vm_OKDuUz+m6eW0t6qVvQpw@mail.gmail.com>
Date:	Mon, 19 May 2014 13:54:02 -0700
From:	David Matlack <matlackdavid@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	Lior Dotan <liodot@...il.com>, linux-kernel@...r.kernel.org,
	charrer@...critech.com
Subject: Re: [PATCH 2/2] staging: slicoss: remove slic_reg_params struct

On Mon, May 19, 2014 at 12:52 PM, Dan Carpenter
<dan.carpenter@...cle.com> wrote:
>
> You have to understand that I review a lot of staging patches every day.
> Most patches try to remove struct members but the code should still work
> exactly as it did before (a clean up).  Some patches remove struct
> members and the behavior changes.  Hopefully it's deliberate and the
> changelog mentions that it is a bug fix.  If it changes the run time,
> and not deliberately then that's a bug.
>

Ah I see. This patch does indeed change the behavior. Since I plan to resend
the other patch in this series, I'll fix the changelog for this patch as well.

Thanks for the review.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/