linux-kernel - Re: [PATCH v2] cpufreq: powernow-k8: Suppress checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 20 May 2014 01:22:12 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Stratos Karafotis <stratosk@...aphore.gr>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] cpufreq: powernow-k8: Suppress checkpatch warnings

On Monday, May 12, 2014 09:52:06 AM Viresh Kumar wrote:
> On 11 May 2014 22:56, Stratos Karafotis <stratosk@...aphore.gr> wrote:
> > Suppress the following checkpatch.pl warnings:
> >
> > - WARNING: Prefer pr_err(... to printk(KERN_ERR ...
> > - WARNING: Prefer pr_info(... to printk(KERN_INFO ...
> > - WARNING: Prefer pr_warn(... to printk(KERN_WARNING ...
> > - WARNING: quoted string split across lines
> > - WARNING: please, no spaces at the start of a line
> >
> > Also, define the pr_fmt macro instead of PFX for the module name.
> >
> > Signed-off-by: Stratos Karafotis <stratosk@...aphore.gr>

Queued up for 3.16, thanks!

> > ---
> >
> > Changes v1 -> v2
> >         - Use pr_err_once instead of printk_once
> >         - Change missing_pss_msg to macro (because pr_err_once
> >         doesn't compile otherwise)
> >         - Put one pr_err message in a single line instead of two
> >         - Ignore "line over 80 characters" warnings
> >         - Change the word "Fix" in the subject of the patch to
> >         "Suppress" as the patch doesn't really fix anything
> >
> >  drivers/cpufreq/powernow-k8.c | 180 +++++++++++++++++-------------------------
> >  drivers/cpufreq/powernow-k8.h |   2 +-
> >  2 files changed, 74 insertions(+), 108 deletions(-)
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/