linux-kernel - Re: [PATCH 2/7] staging: unisys: move uislib/platform proc entry to debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140520010921.GA27462@kroah.com>
Date:	Tue, 20 May 2014 10:09:21 +0900
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	"Romer, Benjamin M" <Benjamin.Romer@...sys.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	*S-Par-Maintainer <SParMaintainer@...sys.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/7] staging: unisys: move uislib/platform proc entry to
 debugfs

On Mon, May 19, 2014 at 10:57:08PM +0300, Dan Carpenter wrote:
> On Mon, May 19, 2014 at 09:42:22AM -0500, Romer, Benjamin M wrote:
> > On Sun, 2014-05-18 at 09:49 -0700, Greg KH wrote:
> > > Also, why are these entries moving to debugfs at all?  Why are they
> > > needed?  Who will use them?  Are tools relying on them to be there?
> > 
> > The tuning entries are sometimes used to help adjust the behavior of our
> > IO service partitions for better performance.
> 
> That sounds like it really belongs in sysfs instead of debugfs.

Exactly.  debugfs files are for "debugging".  Consider them files that
your driver can work properly if no one ever touches them.

"tuning" files imply something that has to be touched by users.
Ideally, you would never need such a thing as no one wants to have to
write things to files to make the kernel work better.  But if you really
need it, they should be sysfs files, with the needed documentation.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/