linux-kernel - Re: [PATCH driver-core-linus] sysfs: make sure read buffer is zeroed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1400549140.19786.6.camel@joe-AO725>
Date:	Mon, 19 May 2014 18:25:40 -0700
From:	Joe Perches <joe@...ches.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, Kay Sievers <kay@...y.org>,
	Ron <ron@...ian.org>, Ben Hutchings <ben@...adent.org.uk>
Subject: Re: [PATCH driver-core-linus] sysfs: make sure read buffer is zeroed

On Mon, 2014-05-19 at 20:49 -0400, Tejun Heo wrote:
> On Mon, May 19, 2014 at 03:32:22PM -0700, Joe Perches wrote:
> > > > +	memset(buf, 0, PAGE_SIZE);
> > 
> > 	memset(buf, 0, count)?
> 
> It's always PAGE_SIZE.  Outputs longer than that are truncated.

Yeah, I know, but the code and comment above it don't match.

/* acquire buffer and ensure that it's >= PAGE_SIZE and clear */



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/