linux-kernel - Re: [PATCH 2/9] usb: gadget: net2280: Dont use magic numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1405201052080.1176-100000@iolanthe.rowland.org>
Date:	Tue, 20 May 2014 10:52:43 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
cc:	"balbi@...com" <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	Joe Perches <joe@...ches.com>,
	Amit Uttamchandani <auttamchandani@...icube.com>
Subject: Re: [PATCH 2/9] usb: gadget: net2280: Dont use magic numbers

On Tue, 20 May 2014, Ricardo Ribalda Delgado wrote:

> Hello Alan
> 
> In this case, there are only two family of devices supported by the
> driver. Maybe quirks are too much.
> 
> At the end:
> 
> ep->dev->pdev->vendor == PCI_VENDOR_ID_PLX_LEGACY
> 
> is not much bigger than
> 
> ep->dev->quirk_flag & PLX_NET2280_QUIRK
> 
> But if you prefer the quirk I dont mind implementing it, but please as
> a follow-up patch, since there are 8 patches depending on this :)

It's not a big deal.  Up to you.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/