linux-kernel - Re: [PATCH] HID: rmi: do not handle touchscreens through hid-rmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140520145916.GB9028@mail.corp.redhat.com>
Date:	Tue, 20 May 2014 14:59:16 +0000
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Andrew Duggan <aduggan@...aptics.com>,
	Christopher Heiny <cheiny@...aptics.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: rmi: do not handle touchscreens through hid-rmi

On May 20 2014 or thereabouts, Jiri Kosina wrote:
> On Wed, 23 Apr 2014, Benjamin Tissoires wrote:
> 
> > Currently, hid-rmi drives every Synaptics product, but the touchscreens
> > on the Windows tablets should be handled through hid-multitouch.
> > 
> > Instead of providing a long list of PIDs, rely on the scan_report
> > capability to detect which should go to hid-multitouch, and which
> > should not go to hid-rmi.
> > 
> > We introduce a generic HID_GROUP_HAVE_SPECIAL_DRIVER which can be reused
> > amoung other drivers if they want to have a catch rule but still
> > have multitouch devices handled through hid-multitouch.
> > 
> > related bug:
> > https://bugzilla.kernel.org/show_bug.cgi?id=74241
> > https://bugzilla.redhat.com/show_bug.cgi?id=1089583
> > 
> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> 
> Hi Benjamin,
> 
> sorry for not responding sooner.

It's not a big deal. Actually, the Canonical folks reminded me the state
of this patch that I completely forgot too :)

> 
> Yes, I have to say I find HID_GROUP_HAVE_SPECIAL_DRIVER very disgusting. 
> Especially its (non-)relation to hid_have_special_driver[] is very 
> confusing.
> 
> If you could update this to be RMI-specific (i.e. create a special 
> HID_GROUP for RMI devices), I'll merge it right away.

Ok, I'll add this to the pile of things to do today.

Cheers,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/