linux-kernel - Re: [PATCH 0/4] mfd: Intel SoC Power Management IC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140520165027.GA32538@lee--X1>
Date:	Tue, 20 May 2014 17:50:28 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Cc:	"Zhu, Lejun" <lejun.zhu@...ux.intel.com>, sameo@...ux.intel.com,
	linux-kernel@...r.kernel.org, bin.yang@...el.com
Subject: Re: [PATCH 0/4] mfd: Intel SoC Power Management IC

> > I'm missing the build files patch.  Can you ensure I was on the
> > distribution list please?  Also, what's the reason for splitting the
> > files out instead of having one single driver?
> 
> The same PMIC may be attached multiple ways, and multiple different PMIC
> types may be attached.
> 
> So for example on the Baytrail/T platforms (ASUS T100 etc) you have
> crystal cove via i2c, but a vendor could use a different PMIC - and there
> will of course always be new PMIC devices coming along.
> 
> Equally on a Z2760 or similar (eg the Lenovo tablet 2) you may well have
> the same PMIC attached to the system control unit. While there's nobody
> afaik trying to sync the Android trees for Clovertrail+ with upstream at
> this point I know there are external to Intel folks working on it for fun
> and we need to allow for that.

Fair enough, I'll bow to your knowledge.  I was just looking at the
current driver and saw the lack of, for instance, intel_soc_pmic_spi.c
which would have warranted separate core/i2c/spi components.  Also the
Kconfig configuration doesn't allow for individual compilation of each
of the source files, which drew me to the conclusion that these could
in fact be centralised.
-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/