linux-kernel - Re: [PATCH 1/6] input: cyapa: rearchitecture driver to support function pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140520034742.GC986@core.coreip.homeip.net>
Date:	Mon, 19 May 2014 20:47:42 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Dudley Du <dudl@...ress.com>
Cc:	Benson Leung <bleung@...gle.com>,
	Daniel Kurtz <djkurtz@...gle.com>,
	David Solda <dso@...ress.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/6] input: cyapa: rearchitecture driver to support
 function pointers

Hi Dudley,

On Wed, Apr 16, 2014 at 08:35:52AM +0000, Dudley Du wrote:
> Re-architecture the driver to support function pointers, so it can support and integrate new devices later in one driver.
> Including use async thread in device proble to speed up system boot time.
> TEST=test on Chomebooks.

There seems to be changes implementing aasync probing intermixed with
the function pointers change, it had to be split out and justification
needs to be provided - I am not quite convinced we should be doing this,
at least not at individual driver level.

Also instead of listing individual function pointers consider defining

struct cyapa_ops {
	void (*irq_handler)(struct cyapa *);
	int (*set_power_mode)(struct cyapa *, u8, u16);
	int (*bl_enter_func)(struct cyapa *);
	....
};

and use const pointer to it in cyapa_state. Then you can have gen3 and
gen5 implementation separated into individual files and the rest forming
cyapa core.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/