linux-kernel - Re: [PATCH] printk: Use symbolic defines for console loglevels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16681.1400564682@turing-police.cc.vt.edu>
Date:	Tue, 20 May 2014 01:44:42 -0400
From:	Valdis.Kletnieks@...edu
To:	Borislav Petkov <bp@...en8.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Randy Dunlap <rdunlap@...radead.org>, x86@...nel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>,
	Jason Wessel <jason.wessel@...driver.com>,
	kgdb-bugreport@...ts.sourceforge.net, Hedi Berriche <hedi@....com>,
	Mike Travis <travis@....com>,
	Dimitri Sivanich <sivanich@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Kees Cook <keescook@...omium.org>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] printk: Use symbolic defines for console loglevels

On Mon, 19 May 2014 20:27:32 +0200, Borislav Petkov said:
> From: Borislav Petkov <bp@...e.de>
>
> ... instead of naked numbers.
>
> Stuff in sysrq.c used to set it to 8 which is supposed to mean above
> default level so set it to DEBUG instead as we're terminating/killing
> all tasks and we want to be verbose there.
>
> There should be no functionality change resulting from this patch.

After a quick eyeballing, looks like it, except for:

> +++ b/arch/x86/kernel/head64.c
> @@ -172,7 +172,7 @@ asmlinkage __visible void __init x86_64_start_kernel(char
 * real_mode_data)
>  	 */
>  	load_ucode_bsp();
>
> -	if (console_loglevel == 10)
> +	if (console_loglevel >= CONSOLE_LOGLEVEL_DEBUG)
>  		early_printk("Kernel alive\n");

But this looks like a bugfix that changes the behavior for loglevels > 11.

Having said that, it's probably OK to not split the bugfix out to
a separate patch....

Content of type "application/pgp-signature" skipped