linux-kernel - RE: [PATCH] scsi: bfa: bfa_fcs_lport.c: Fix for possible null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20B1A3CBD98F3845B3F5F56D8597EF59F8930D@avmb2.qlogic.org>
Date:	Wed, 21 May 2014 06:28:31 +0000
From:	Anil Gurumurthy <Anil.Gurumurthy@...gic.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	"Sudarsana Kalluru" <Sudarsana.Kalluru@...gic.com>
CC:	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: bfa: bfa_fcs_lport.c:  Fix for possible null
 pointer dereference

Thanks for the patch.
Acked-by: Anil Gurumurthy <anil.gurumurthy@...gic.com>

-----Original Message-----
From: Rickard Strandqvist [mailto:rickard_strandqvist@...ctrumdigital.se]
Sent: 18 May 2014 21:36
To: Anil Gurumurthy; Sudarsana Kalluru
Cc: Rickard Strandqvist; James E.J. Bottomley; linux-scsi; linux-kernel
Subject: [PATCH] scsi: bfa: bfa_fcs_lport.c: Fix for possible null pointer dereference

There is otherwise a risk of a possible null pointer dereference.

Was largely found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
---
 drivers/scsi/bfa/bfa_fcs_lport.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c
index ff75ef8..542d5c6 100644
--- a/drivers/scsi/bfa/bfa_fcs_lport.c
+++ b/drivers/scsi/bfa/bfa_fcs_lport.c
@@ -5826,12 +5826,13 @@ bfa_fcs_lport_get_rport_max_speed(bfa_fcs_lport_t *port)
        bfa_port_speed_t max_speed = 0;
        struct bfa_port_attr_s port_attr;
        bfa_port_speed_t port_speed, rport_speed;
-       bfa_boolean_t trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
+       bfa_boolean_t trl_enabled;


        if (port == NULL)
                return 0;

+       trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
        fcs = port->fcs;

        /* Get Physical port's current speed */
--
1.7.10.4


________________________________

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/