linux-kernel - RE: [PATCH] iommu: fsl_pamu.c: Fix for possible null pointer dereference

Open Source and information security mailing list archives

Message-ID: <687709ad1a974bf5a2508b2e78b316d3@BL2PR03MB468.namprd03.prod.outlook.com>
Date:	Wed, 21 May 2014 07:15:28 +0000
From:	Varun Sethi <Varun.Sethi@...escale.com>
To:	"Bharat.Bhushan@...escale.com" <Bharat.Bhushan@...escale.com>,
	"Rickard Strandqvist" <rickard_strandqvist@...ctrumdigital.se>,
	Joerg Roedel <joro@...tes.org>,
	Grant Likely <grant.likely@...aro.org>
CC:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
	"Rob Herring" <robh+dt@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] iommu: fsl_pamu.c: Fix for possible null pointer
	dereference


> -----Original Message-----
> From: iommu-bounces@...ts.linux-foundation.org [mailto:iommu-
> bounces@...ts.linux-foundation.org] On Behalf Of
> Bharat.Bhushan@...escale.com
> Sent: Wednesday, May 21, 2014 9:28 AM
> To: Rickard Strandqvist; Joerg Roedel; Grant Likely
> Cc: devicetree@...r.kernel.org; iommu@...ts.linux-foundation.org; Rob
> Herring; linux-kernel@...r.kernel.org
> Subject: RE: [PATCH] iommu: fsl_pamu.c: Fix for possible null pointer
> dereference
> 
> 
> 
> > -----Original Message-----
> > From: iommu-bounces@...ts.linux-foundation.org [mailto:iommu-
> > bounces@...ts.linux-foundation.org] On Behalf Of Rickard Strandqvist
> > Sent: Saturday, May 17, 2014 10:47 PM
> > To: Joerg Roedel; Grant Likely
> > Cc: devicetree@...r.kernel.org; iommu@...ts.linux-foundation.org; Rob
> > Herring; linux-kernel@...r.kernel.org; Rickard Strandqvist
> > Subject: [PATCH] iommu: fsl_pamu.c: Fix for possible null pointer
> > dereference
> >
> > There is otherwise a risk of a possible null pointer dereference.
> 
> You are right.
[Sethi Varun-B16395] Thanks for pointing out the issue.
> 
> >
> > Was largely found by using a static code analysis program called
> cppcheck.
> >
> > Signed-off-by: Rickard Strandqvist
> > <rickard_strandqvist@...ctrumdigital.se>
> 
> Reviewed-by: Bharat Bhushan <bharat.bhushan@...escale.com>
Acknowledged-by: Varun Sethi <Varun.Sethi@...escale.com>

> > ---
> >  drivers/iommu/fsl_pamu.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c index
> > cba0498..b99dd88 100644
> > --- a/drivers/iommu/fsl_pamu.c
> > +++ b/drivers/iommu/fsl_pamu.c
> > @@ -592,8 +592,7 @@ found_cpu_node:
> >  		/* advance to next node in cache hierarchy */
> >  		node = of_find_node_by_phandle(*prop);
> >  		if (!node) {
> > -			pr_debug("Invalid node for cache hierarchy %s\n",
> > -				node->full_name);
> > +			pr_debug("Invalid node for cache hierarchy\n");
> >  			return ~(u32)0;
> >  		}
> >  	}
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > iommu mailing list
> > iommu@...ts.linux-foundation.org
> > https://lists.linuxfoundation.org/mailman/listinfo/iommu
> _______________________________________________
> iommu mailing list
> iommu@...ts.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives