linux-kernel - 回复： [PATCH] arch: unicore32: kernel: ksyms: remove 'bswapsi2' and 'muldi3' to avoid compiling failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <911514109.40740.1400659115169.JavaMail.root@bj-mail03.pku.edu.cn>
Date:	Wed, 21 May 2014 15:58:35 +0800 (CST)
From:	管雪涛 <gxt@....edu.cn>
To:	Chen Gang <gang.chen.5i5j@...il.com>
Cc:	Guan Xuetao <gxt@...c.pku.edu.cn>, linux-kernel@...r.kernel.org
Subject: 回复： [PATCH] arch: unicore32: kernel: ksyms: remove 'bswapsi2' and 'muldi3' to avoid compiling failure

Thanks.

For __muldi3, it is no longer used by gcc, so I think that's ok.
For __bswapsi2, maybe it's because I copied it from arm.

Acked-by: Xuetao Guan <gxt@...c.pku.edu.cn>

----- Chen Gang <gang.chen.5i5j@...il.com> 写道：
> After check the code, 'bswapsi2' and 'muldi3' are useless for
> unicore32, so can remove them to avoid compiling failure.
> 
> The related error (with allmodconfig under unicore32):
> 
>     LD      init/built-in.o
>   arch/unicore32/kernel/built-in.o:(___ksymtab+__muldi3+0x0): undefined reference to `__muldi3'
>   arch/unicore32/kernel/built-in.o:(___ksymtab+__bswapsi2+0x0): undefined reference to `__bswapsi2'
> 
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> ---
>  arch/unicore32/kernel/ksyms.c | 2 --
>  arch/unicore32/kernel/ksyms.h | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/arch/unicore32/kernel/ksyms.c b/arch/unicore32/kernel/ksyms.c
> index bc06140..e78911a 100644
> --- a/arch/unicore32/kernel/ksyms.c
> +++ b/arch/unicore32/kernel/ksyms.c
> @@ -53,9 +53,7 @@ EXPORT_SYMBOL(__ashrdi3);
>  EXPORT_SYMBOL(__divsi3);
>  EXPORT_SYMBOL(__lshrdi3);
>  EXPORT_SYMBOL(__modsi3);
> -EXPORT_SYMBOL(__muldi3);
>  EXPORT_SYMBOL(__ucmpdi2);
>  EXPORT_SYMBOL(__udivsi3);
>  EXPORT_SYMBOL(__umodsi3);
> -EXPORT_SYMBOL(__bswapsi2);
>  
> diff --git a/arch/unicore32/kernel/ksyms.h b/arch/unicore32/kernel/ksyms.h
> index 185cdc7..31472ad 100644
> --- a/arch/unicore32/kernel/ksyms.h
> +++ b/arch/unicore32/kernel/ksyms.h
> @@ -8,8 +8,6 @@ extern void __ashrdi3(void);
>  extern void __divsi3(void);
>  extern void __lshrdi3(void);
>  extern void __modsi3(void);
> -extern void __muldi3(void);
>  extern void __ucmpdi2(void);
>  extern void __udivsi3(void);
>  extern void __umodsi3(void);
> -extern void __bswapsi2(void);
> -- 
> 1.9.2.459.g68773ac

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/