linux-kernel - 回复： Re: 回复： [PATCH] arch/unicore32/kernel/setup.c: add generic 'screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1381816856.42144.1400664218906.JavaMail.root@bj-mail03.pku.edu.cn>
Date:	Wed, 21 May 2014 17:23:38 +0800 (CST)
From:	管雪涛 <gxt@....edu.cn>
To:	Chen Gang <gang.chen.5i5j@...il.com>
Cc:	Guan Xuetao <gxt@...c.pku.edu.cn>, linux-kernel@...r.kernel.org
Subject: 回复： Re: 回复： [PATCH] arch/unicore32/kernel/setup.c: add generic 'screen_info' to avoid compiling failure


----- Chen Gang <gang.chen.5i5j@...il.com> 写道：
> 
> Yeah, I shall send patch v2 for it (within this week). And also thank
> you for your review the other patches.
> 
> BTW: I guess, it only leaves 2 kernel related issues for allmodconfig:
> 
>  - one for 'find_first*', 'cpuc_coherent_kern_range' and 'pm_power_off'.
>    I guess, we can export their symbol explicitly to fix this issue.

My suggestion:
 find_first_* could export themselves in lib/find_first.c, so each archs can use it.
   anyway, we can first add them in unicore32, and then make it a generic lib.
 what's the problem with cpuc_coherent_kern_range? in fact, I'll remove it later.
 pm_power_off need be exported.

> 
>  - the other for additional 'clk_*' which are needed when HAVE_CLK.
>    I guess, just "copy/past" the other platforms' implementation is OK.

Maybe, COMMON_CLK should be selected. I'm not sure.

> 
> The related errors:
> 
>   ERROR: "clk_round_rate" [sound/spi/snd-at73c213.ko] undefined!
>   ERROR: "clk_set_parent" [sound/soc/jz4740/snd-soc-jz4740-i2s.ko] undefined!
>   ERROR: "clk_round_rate" [sound/soc/fsl/snd-soc-fsl-ssi.ko] undefined!
>   ERROR: "clk_round_rate" [sound/soc/fsl/snd-soc-fsl-spdif.ko] undefined!
>   ERROR: "find_first_bit" [sound/soc/codecs/snd-soc-uda1380.ko] undefined!
>   ERROR: "find_first_zero_bit" [net/sctp/sctp.ko] undefined!
>   ERROR: "find_first_bit" [net/phonet/phonet.ko] undefined!
>   ERROR: "find_first_zero_bit" [net/nfc/nfc.ko] undefined!
>   ERROR: "find_first_zero_bit" [net/netfilter/nf_tables.ko] undefined!
>   ERROR: "find_first_bit" [net/mac80211/mac80211.ko] undefined!
>   ERROR: "find_first_zero_bit" [net/bridge/bridge.ko] undefined!
>   ERROR: "find_first_bit" [net/bridge/bridge.ko] undefined!
>   ERROR: "find_first_zero_bit" [fs/reiserfs/reiserfs.ko] undefined!
>   ERROR: "find_first_bit" [fs/ocfs2/ocfs2.ko] undefined!
>   ERROR: "find_first_zero_bit" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
>   ERROR: "find_first_bit" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
>   ERROR: "find_first_zero_bit" [fs/nfs/nfsv4.ko] undefined!
>   ERROR: "find_first_zero_bit" [fs/minix/minix.ko] undefined!
>   ERROR: "find_first_bit" [fs/hfsplus/hfsplus.ko] undefined!
>   ERROR: "find_first_zero_bit" [fs/gfs2/gfs2.ko] undefined!
>   ERROR: "find_first_zero_bit" [fs/bfs/bfs.ko] undefined!
>   ERROR: "find_first_zero_bit" [drivers/uwb/uwb.ko] undefined!
>   ...
> 
> Thanks.
> -- 
> Chen Gang
> 
> Open, share, and attitude like air, water, and life which God blessed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/