linux-kernel - Re: [PATCH] 9P: fix return value in v9fs_fid_xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <537CA69F.7080603@elastichosts.com>
Date:	Wed, 21 May 2014 14:14:07 +0100
From:	Alin Dobre <alin.dobre@...stichosts.com>
To:	Dominique Martinet <dominique.martinet@....fr>,
	v9fs-developer@...ts.sourceforge.net,
	Eric Van Hensbergen <ericvh@...il.com>
CC:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ron Minnich <rminnich@...dia.gov>,
	Latchesar Ionkov <lucho@...kov.net>
Subject: Re: [PATCH] 9P: fix return value in v9fs_fid_xattr_set

On 21/05/14 09:02, Dominique Martinet wrote:
> v9fs_fid_xattr_set is supposed to return 0 on success.
> 
> This corrects the behaviour introduced in commit
> bdd5c28dcb8330b9074404cc92a0b83aae5606a
> "9p: fix return value in case in v9fs_fid_xattr_set()"
> 
> (The function returns a negative error on error, as expected)
> 
> Signed-off-by: Dominique Martinet <dominique.martinet@....fr>
> ---
>  fs/9p/xattr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/9p/xattr.c b/fs/9p/xattr.c
> index 04133a1..f95e01e 100644
> --- a/fs/9p/xattr.c
> +++ b/fs/9p/xattr.c
> @@ -156,7 +156,7 @@ int v9fs_fid_xattr_set(struct p9_fid *fid, const char *name,
>  		offset += write_count;
>  		value_len -= write_count;
>  	}
> -	retval = offset;
> +	retval = 0;
>  err:
>  	p9_client_clunk(fid);
>  	return retval;
> 

This patch seems to be fixing the problem, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/