linux-kernel - Re: [PATCH] scripts/tags.sh: ignore symlink'ed source files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 May 2014 11:27:34 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Yann Droneaud <ydroneaud@...eya.com>
Cc:	Michal Marek <mmarek@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Sam Ravnborg <sam@...nborg.org>,
	Joonsoo Kim <js1304@...il.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Ian Campbell <ijc@...lion.org.uk>,
	Jiri Slaby <jirislaby@...il.com>, linux-kernel@...r.kernel.org,
	Michael Ellerman <mpe@...erman.id.au>,
	Anton Blanchard <anton@...ba.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Hans-Bernhard Bröker 
	<broeker@...rs.sourceforge.net>,
	Hans-Bernhard Broeker <broeker@...sik.rwth-aachen.de>,
	Neil Horman <nhorman@...rs.sourceforge.net>,
	Gerhard Sittig <gsi@...x.de>,
	Konstantin Khlebnikov <koct9i@...il.com>
Subject: Re: [PATCH] scripts/tags.sh: ignore symlink'ed source files

On Wed, May 21, 2014 at 03:32:17PM +0200, Yann Droneaud wrote:
> Since commit 22d651dcef536c75f75537290bf3da5038e68b6b ('selftests/powerpc:
> Import Anton's memcpy / copy_tofrom_user tests'), some source files in the
> tree appear as symlink.
> Until commit 8c38a5328af8080bc69a25b3e4e144b03eeea95e ('scripts/tags.sh:
> ignore code of user space tools'), those symlinks made cscope report some
> warnings:
> 
>     $ make ALLSOURCE_ARCHS=all O=./obj-cscope/ cscope
>       GEN     cscope
>     cscope: cannot find
> file .../tools/testing/selftests/powerpc/copyloops/copyuser_power7.S
>     cscope: cannot find
> file .../tools/testing/selftests/powerpc/copyloops/memcpy_64.S
>     cscope: cannot find
> file .../tools/testing/selftests/powerpc/copyloops/memcpy_power7.S
>     cscope: cannot find
> file .../tools/testing/selftests/powerpc/copyloops/copyuser_64.S
> 
> In order to prevent the same kind of warnings to be triggered by future
> addition of symlinks, the best option is to ignore all symlinks when
> building the file list to be processed by cscope (and other tools
> supported by scripts/tags.sh).
> 
> Ignoring symlinks won't hide source files from cscope (and others) as the
> target of these symlinks already appear somewhere else in the tree, and,
> as such, should be processed by cscope (or others).
> 
> Note that, cscope, when used with -R option to make it find the files to
> process by itself, already skip symlinks: it's not expected that cscope
> access source files through symlink.
> 
> On top of commit 8c38a5328af8080bc69a25b3e4e144b03eeea95e ('scripts/tags.sh:
> ignore code of user space tools'), scripts/tags.sh output from
> "make cscope tags TAGS" is the same with and without this patch: it doesn't
> seems to introduce any regression (on Fedora 20).
> 
> Link: http://lkml.kernel.org/r/1396530975.4361.28.camel@localhost.localdomain
> Link: http://mid.gmane.org/534312F8.5090609@t-online.de
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Anton Blanchard <anton@...ba.org>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Hans-Bernhard Bröker <broeker@...rs.sourceforge.net>,
> Cc: Hans-Bernhard Broeker <broeker@...sik.rwth-aachen.de>,
> Cc: Neil Horman <nhorman@...rs.sourceforge.net>
> Cc: Neil Horman <nhorman@...driver.com>
> Cc: Gerhard Sittig <gsi@...x.de>
> Cc: Konstantin Khlebnikov <koct9i@...il.com>
> Signed-off-by: Yann Droneaud <ydroneaud@...eya.com>
> 
Acked-by: Neil Horman <nhorman@...driver.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/