lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 May 2014 18:04:43 +0200 From: Arnd Bergmann <arnd@...db.de> To: linux-arm-kernel@...ts.infradead.org Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>, andriy.shevchenko@...el.com, Vinod Koul <vinod.koul@...el.com>, linux-kernel@...r.kernel.org, zhuzhenhua@...winnertech.com, shuge@...winnertech.com, linux-sunxi@...glegroups.com, kevin.z.m.zh@...il.com, sunny@...winnertech.com, dmaengine@...r.kernel.org, Dan Williams <dan.j.williams@...el.com> Subject: Re: [PATCH v8 0/2] Add support for the Allwinner A31 DMA Controller On Wednesday 21 May 2014 17:55:51 Maxime Ripard wrote: > On Wed, May 21, 2014 at 05:23:41PM +0200, Arnd Bergmann wrote: > > On Wednesday 21 May 2014 17:15:54 Maxime Ripard wrote: > > > Changes from v7: > > > - select DMA_OF, since we're only relying on DT > > > > > > > I missed the discussion about this issue, but it seems wrong to me. > > DMA_OF is currently enabled if we have both DMAENGINE and OF turned on. > > > > If OF is disabled but DMA_OF gets selected by DMA_SUN6I, what happens? > > Is that even possible with a multiplatform-based platform? It's not possible for ARCH_SUNXI or any other that depends on ARCH_MULTIPLATFORM. I just noticed that you have 'depends on ARCH_SUNXI', so the 'select DMA_OF' statement is just redundant, not wrong. However, if the driver was 'depends on ARCH_SUNXI || COMPILE_TEST' as many others are nowadays, it would be a bug. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists