linux-kernel - Re: [PATCH] cpufreq: intel_pstate: Remove unused member name of cpudata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <537CDF46.3000007@gmail.com>
Date:	Wed, 21 May 2014 10:15:50 -0700
From:	Dirk Brandewie <dirk.brandewie@...il.com>
To:	Stratos Karafotis <stratosk@...aphore.gr>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Dirk Brandewie <dirk.j.brandewie@...el.com>
CC:	dirk.brandewie@...il.com,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org >> LKML" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: intel_pstate: Remove unused member name of cpudata

On 05/20/2014 11:12 AM, Stratos Karafotis wrote:
> Although, a value is assigned to member name of struct cpudata,
> it is never used.
>
> We can safely remove it.
>
> Signed-off-by: Stratos Karafotis <stratosk@...aphore.gr>

Acked-by: Dirk Brandewie <dirk.j.brandewie@...el.com>
> ---
>   drivers/cpufreq/intel_pstate.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 24a534a..a6d5afa 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -88,8 +88,6 @@ struct _pid {
>   struct cpudata {
>   	int cpu;
>
> -	char name[64];
> -
>   	struct timer_list timer;
>
>   	struct pstate_data pstate;
> @@ -544,8 +542,6 @@ static inline void intel_pstate_pstate_decrease(struct cpudata *cpu, int steps)
>
>   static void intel_pstate_get_cpu_pstates(struct cpudata *cpu)
>   {
> -	sprintf(cpu->name, "Intel 2nd generation core");
> -
>   	cpu->pstate.min_pstate = pstate_funcs.get_min();
>   	cpu->pstate.max_pstate = pstate_funcs.get_max();
>   	cpu->pstate.turbo_pstate = pstate_funcs.get_turbo();
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/