linux-kernel - [PATCH V5 0/4] x86/pci Fix numa_node info for AMD hostbridge and misc clean up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 May 2014 17:17:57 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
Cc:	Robert Richter <rric@...nel.org>,
	Daniel J Blueman <daniel@...ascale.com>,
	Andreas Herrmann <herrmann.der.user@...glemail.com>,
	linux-kernel@...r.kernel.org,
	Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>,
	linux-pci@...r.kernel.org, Borislav Petkov <bp@...e.de>,
	Myron Stowe <myron.stowe@...hat.com>
Subject: [PATCH V5 0/4] x86/pci Fix numa_node info for AMD hostbridge and
 misc clean up

[resending because I forgot to copy the lists, sorry guys]

Hi Suravee,

Sorry it took me so long to get to these patches.  Here's my proposal.  I
reordered them and added some comments in the code and changelogs, but I
think your patches look fine as-is.

So I just need comments on these two significant changes:

  1) I added a patch to stop enabling ECS after Fam16h, because that's
  another case of CPU-dependent code that we should not need to keep
  carrying.  I don't think there are any post-Fam16h CPUs yet, but I
  certainly don't want to do anything that will keep them from working when
  they do arrive.  It would be useful if somebody could test this on
  current platforms by tweaking the patch so we don't enable ECS on Fam15h.

  2) I dropped the quirk_amd_nb_node() removal.  I could be convinced
  otherwise, but I don't really object to the quirk because it is already
  explicitly limited to specific devices, and removing it will change
  things in sysfs.  I think the changes would be harmless as far as the
  kernel is concerned, since there are no drivers for these devices.  But
  Andreas added the quirk because of complaints, so apparently somebody is
  looking at what's in sysfs, and I don't want to get the same complaints
  again by removing it.  However, I will certainly ask questions if I see
  the quirk being extended to more devices.

The AMD BKDG does say the BIOS should provide an MCFG table (sec 2.8 of
42301), so I think it provides guidance matching the intent of my "stop
enabling ECS" patch.  But the BKDG doesn't mention _PXM at all.  Is there
any chance you could squeeze in a mention of that, so BIOS writers know
that they *should* provide it?  I want to avoid more fire-drills in the
future.

Bjorn

---

Bjorn Helgaas (1):
      x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

Myron Stowe (1):
      x86/PCI: Warn if we have to "guess" host bridge node information

Suravee Suthikulpanit (2):
      x86/PCI: Work around AMD Fam15h BIOSes that fail to provide _PXM
      x86/PCI: Clean up and mark early_root_info_init() as deprecated

 arch/x86/pci/acpi.c    |    6 +++
 arch/x86/pci/amd_bus.c |   87 +++++++++++++++++++++++++++++++-----------------
 2 files changed, 62 insertions(+), 31 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/