linux-kernel - Re: [PATCH V5] PM/OPP: discard duplicate OPPs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5258228.rMTDJps2Fm@vostro.rjw.lan>
Date:	Thu, 22 May 2014 01:48:43 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Arvind Chauhan <arvind.chauhan@....com>,
	Ips Gandhi <inderpal.s@...sung.com>,
	Nishanth Menon <nm@...com>,
	Chander Kashyap <chander.kashyap@...aro.org>,
	Pavel Machek <pavel@....cz>,
	"Brown, Len" <len.brown@...el.com>,
	Chander Kashyap <k.chander@...sung.com>
Subject: Re: [PATCH V5] PM/OPP: discard duplicate OPPs

On Wednesday, May 21, 2014 09:33:42 AM Viresh Kumar wrote:
> On 21 May 2014 02:39, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
> >> +     /* Duplicate OPPs ? */
> >> +     if (new_opp->rate == opp->rate) {
> >> +             int ret = (new_opp->u_volt == opp->u_volt) && opp->available ?
> >> +                     0 : -EEXIST;
> >
> > The parens are not necessary.  And is the direction correct?
> 
> What do you mean by direction here ?

The case in which we want to return 0.  Never mind, it's OK.  The parens are still
not necessary, though.


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/