| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140521053153.GA26431@chokladfabriken.org> Date: Wed, 21 May 2014 08:31:54 +0300 From: Stefan Kristiansson <stefan.kristiansson@...nalahti.fi> To: Jonas Bonn <jonas@...thpole.se> Cc: linux-kernel@...r.kernel.org, linux@...ts.openrisc.net Subject: Re: [PATCH] openrisc: irq: use irqchip framework On Tue, May 20, 2014 at 08:45:44AM +0200, Jonas Bonn wrote: > On 05/19/2014 09:54 PM, Stefan Kristiansson wrote: > > On Mon, May 19, 2014 at 04:44:57PM +0200, Jonas Bonn wrote: > > > >> ii) Put a Depends on CONFIG_ARCH_OPENRISC in the Kconfig > > > > Hmm, do we really need that? > > The irqchip driver will picked by 'select'ing it from arch/openrisc/Kconfig > > So, it won't really be exposed to anyone not explicitly picking it like that. > > > > It will be exposed by allyesconfig. allyesconfig is still ARCH specific, so it will not be exposed by that. > The driver uses mfspr which is > openrisc-only, so the driver really needs to hide behind an > openrisc-arch config option. > Yes, I understand that this needs to be OpenRISC only, but usually it is frown upon adding things to the Kconfig that are implied by the default behaviour. And I believe the default behaviour does imply this, OpenRISC will be the only ARCH that will pick this driver. Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists