lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 May 2014 13:53:41 +0530 From: Sachin Kamat <sachin.kamat@...aro.org> To: Paul Bolle <pebolle@...cali.nl> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, Viresh Kumar <viresh.kumar@...aro.org>, "cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] cpufreq: s5pv210: remove unused call of pr_err() Hi Paul, On 22 May 2014 12:11, Paul Bolle <pebolle@...cali.nl> wrote: > Sachin, > > On Thu, 2014-05-22 at 08:52 +0530, Sachin Kamat wrote: >> The config symbol itself is not defined and hence could be removed. >> However I feel, the >> error message could be retained after trimming down the arguments a bit. > > My reasoning is, of course, that never used code can simply be dropped. Yes, I agree. However the error message in this case should have been outside the ifdefs to begin with as it is not an extra information but an essential message reporting error condition. > > But you want to print an error here. That's fine with me. I prefer if > you'd submit a patch that does that, as I have no idea whatsoever why an > error is needed here nor what that error should say. You may just remove the __FILE__ and __LINE__ thing and leave the message as is. pr_err("Denied access to %s as it is disabled temporarily\n", __func__); -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists