linux-kernel - Re: [PATCH 03/03] staging: board: kzm9d: Board staging support for emxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWyCN7UJ89xjpAj-X7rTHo_r0U6XJJwMOxGnXAeeYZXHQ@mail.gmail.com>
Date:	Thu, 22 May 2014 11:19:33 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Magnus Damm <magnus.damm@...il.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	driverdevel <devel@...verdev.osuosl.org>,
	Linux-sh list <linux-sh@...r.kernel.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	Simon Horman <horms@...ge.net.au>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Olof Johansson <olof@...om.net>
Subject: Re: [PATCH 03/03] staging: board: kzm9d: Board staging support for emxx_udc

Hi Magnus,

On Thu, May 22, 2014 at 10:54 AM, Magnus Damm <magnus.damm@...il.com> wrote:
> Add staging board support for the KZM9D board and add
> an emxx_udc platform device to allow in-tree continous
> development of the driver on the KZM9D board.
>
> When DT bindings are ready for the emxx_udc driver then
> the platform device in the KZM9D staging board code can
> easily be removed. Until then we use platform devices
> to continously improve the driver and integration code.

Nice!

>  drivers/staging/Kconfig        |    2 ++
>  drivers/staging/Makefile       |    1 +
>  drivers/staging/board/Kconfig  |    7 +++++++
>  drivers/staging/board/Makefile |    1 +
>  drivers/staging/board/board.h  |   17 +++++++++++++++++
>  drivers/staging/board/kzm9d.c  |   18 ++++++++++++++++++
>  6 files changed, 46 insertions(+)

As you're adding infrastructure and a first user, I think this should
be split in two patches:
  - Introduction of drivers/staging/board infrastructure,
  - Addition of kzm9d board support.

> --- /dev/null
> +++ work/drivers/staging/board/Kconfig  2014-05-22 15:31:58.000000000 +0900
> @@ -0,0 +1,7 @@
> +config STAGING_BOARD
> +       boolean "Staging Board Support"
> +       help
> +         Select to enable per-board staging support code.
> +
> +         If in doubt, say N here.
> +

No board-specific Kconfig symbols, so the actual individual board
support itself is
always compiled-in (but see below)?

> --- /dev/null
> +++ work/drivers/staging/board/Makefile 2014-05-22 15:31:58.000000000 +0900
> @@ -0,0 +1 @@
> +obj-$(CONFIG_ARCH_SHMOBILE_MULTI)      += kzm9d.o

Ah, it's included in all shmobile multi-platform kernels.

What about testing for CONFIG_ARCH_EMEV2 instead of
CONFIG_ARCH_SHMOBILE_MULTI?
Or adding a KZM9D-specific Kconfig symbol to .../board/Kconfig?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/