linux-kernel - [PATCH] intel_rapl: Correct hotplug correction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 May 2014 11:23:44 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Borislav Petkov <bp@...e.de>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Ingo Molnar <mingo@...nel.org>,
	Jacob Pan <jacob.jun.pan@...ux.intel.com>,
	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Subject: [PATCH] intel_rapl: Correct hotplug correction

From: Borislav Petkov <bp@...e.de>

So 009f225ef050 ("powercap, intel-rapl: Fix CPU hotplug callback
registration") says how get_/put_online_cpus() should be replaced with
this cpu_notifier_register_begin/_done().

But they're still there so what's up?

Let me do what was supposed to be done.

Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc: Ingo Molnar <mingo@...nel.org>
Cc: Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc: Srivatsa S. Bhat <srivatsa.bhat@...ux.vnet.ibm.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
Signed-off-by: Borislav Petkov <bp@...e.de>
---
 drivers/powercap/intel_rapl.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index d9a0770b6c73..9055f3df1f64 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1377,8 +1377,6 @@ static int __init rapl_init(void)
 
 	cpu_notifier_register_begin();
 
-	/* prevent CPU hotplug during detection */
-	get_online_cpus();
 	ret = rapl_detect_topology();
 	if (ret)
 		goto done;
@@ -1390,7 +1388,6 @@ static int __init rapl_init(void)
 	}
 	__register_hotcpu_notifier(&rapl_cpu_notifier);
 done:
-	put_online_cpus();
 	cpu_notifier_register_done();
 
 	return ret;
-- 
1.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/