linux-kernel - Re: [PATCH] i2c: davinci: Add block read functionality for IPMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 May 2014 16:21:29 +0530
From:	Sekhar Nori <nsekhar@...com>
To:	Murali Karicheri <m-karicheri2@...com>,
	<davinci-linux-open-source@...ux.davincidsp.com>,
	<linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:	Garrett Ding <g-ding@...com>,
	Kevin Hilman <khilman@...prootsystems.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Santosh Shilimkar <santosh.shilimkar@...com>
Subject: Re: [PATCH] i2c: davinci: Add block read functionality for IPMI

On Friday 02 May 2014 12:19 AM, Murali Karicheri wrote:
> Intelligent Plaform Management Interface (IPMI) requires I2C driver
> to support block read, where the first byte received from slave is
> the length of following data:-
>  Added length check if the read type is block read (I2C_M_RECV_LEN)
>  Send NACK/STOP bits before last byte is received
> 
> Signed-off-by: Garrett Ding <g-ding@...com>
> Signed-off-by: Murali Karicheri <m-karicheri2@...com>

I tested this on a DA850 using i2cdetect and it did not seem to break 
anything so:

Tested-by: Sekhar Nori <nsekhar@...com>

There are some checks that were triggered in checkpatch. You may want 
to fix them up.

Thanks,
Sekhar

CHECK: Alignment should match open parenthesis
#112: FILE: drivers/i2c/busses/i2c-davinci.c:557:
+					w = davinci_i2c_read_reg(dev,
+							DAVINCI_I2C_MDR_REG);

CHECK: Alignment should match open parenthesis
#115: FILE: drivers/i2c/busses/i2c-davinci.c:560:
+					davinci_i2c_write_reg(dev,
+							DAVINCI_I2C_MDR_REG, w);

CHECK: Alignment should match open parenthesis
#119: FILE: drivers/i2c/busses/i2c-davinci.c:564:
+					davinci_i2c_write_reg(dev,
+							DAVINCI_I2C_MDR_REG, w);

total: 0 errors, 0 warnings, 3 checks, 67 lines checked

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/