linux-kernel - Re: [PATCH v3] gpio: Add support for Intel SoC PMIC (Crystal Cove)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140522111554.GG1651@lahna.fi.intel.com>
Date:	Thu, 22 May 2014 14:15:54 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	"Zhu, Lejun" <lejun.zhu@...ux.intel.com>
Cc:	linus.walleij@...aro.org, gnurou@...il.com,
	mathias.nyman@...ux.intel.com, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, jacob.jun.pan@...ux.intel.com,
	bin.yang@...el.com
Subject: Re: [PATCH v3] gpio: Add support for Intel SoC PMIC (Crystal Cove)

On Thu, May 22, 2014 at 12:59:03PM +0800, Zhu, Lejun wrote:
> +static int crystalcove_gpio_probe(struct platform_device *pdev)
> +{
> +	int irq = platform_get_irq(pdev, 0);
> +	struct crystalcove_gpio *cg;
> +	int retval;
> +	struct device *dev = pdev->dev.parent;
> +
> +	cg = devm_kzalloc(&pdev->dev, sizeof(*cg), GFP_KERNEL);
> +	if (!cg) {

A minor comment here:

return -ENOMEM;

> +		retval = -ENOMEM;
> +		goto out;
> +	}

Other than that this looks good to me,

Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

I suppose this is dependent on the MFD driver right? If so, this should
probably be merged along with that patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/