lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 21 May 2014 19:51:11 -0700 (PDT)
From:	David Rientjes <>
To:	Vlastimil Babka <>
cc:	Andrew Morton <>,
	Hugh Dickins <>,
	Greg Thelen <>,,, Minchan Kim <>,
	Mel Gorman <>,
	Joonsoo Kim <>,
	Bartlomiej Zolnierkiewicz <>,
	Michal Nazarewicz <>,
	Naoya Horiguchi <>,
	Christoph Lameter <>,
	Rik van Riel <>
Subject: Re: [PATCH v2 2/2] mm/compaction: avoid rescanning pageblocks in

On Mon, 19 May 2014, Vlastimil Babka wrote:

> Fix a (spurious) build warning:
> mm/compaction.c:860:15: warning: ‘next_free_pfn’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> Seems like the compiler cannot prove that exiting the for loop without updating
> next_free_pfn there will mean that the check for crossing the scanners will
> trigger. So let's not confuse people who try to see why this warning occurs.
> Instead of initializing next_free_pfn to zero with an explaining comment, just
> drop the damned variable altogether and work with cc->free_pfn directly as
> Nayoa originally suggested.


> Suggested-by: Naoya Horiguchi <>
> Signed-off-by: Vlastimil Babka <>

Acked-by: David Rientjes <>

Powered by blists - more mailing lists