linux-kernel - Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140522132645.GC10287@linux-mips.org>
Date:	Thu, 22 May 2014 15:26:45 +0200
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: cavium-octeon: remove checks for CONFIG_CAVIUM_GDB

On Tue, May 20, 2014 at 06:16:14PM +0200, Paul Bolle wrote:

> Three checks for CONFIG_CAVIUM_GDB were added in v2.6.29. But the
> Kconfig symbol CAVIUM_GDB was never added to the tree. Remove these
> checks.
> 
> Also remove the last reference to octeon_get_boot_debug_flag(). There is
> no definition of that function anyway.
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>

Queued for 3.16.  Thanks Paul & Andreas!

> A follow up might be to remove plat_smp_ops.cpus_done. All these
> callbacks are now (basically) nops.

I'll think about it.  The hook is no useful if unused then again now and
then ordering issues in SMP startup of secondary CPUs are showing up and
it may be useful to solve those.  Maybe something like

void __init smp_cpus_done(unsigned int max_cpus)
{
- 	mp_ops->cpus_done();
+ 	if (cpus_done)
+ 		mp_ops->cpus_done();
}

which would make a NULL cpus_done function pointer safe and allow empty definitions
to be removed.

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/